HDDS-6365. Relax protolock rule to allow changing field names

Open smengcl opened this issue 3 years ago • 1 comments

What changes were proposed in this pull request?

Set strict to false in protolock command line. See the jira description for more details.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-6365

How was this patch tested?

[x] Should build successfully.
[ ] All tests should pass.
[ ] Check for any potential JSON usage.

Feb 23 '22 05:02 smengcl

@smengcl @adoroszlai Any new thoughts about this PR?

Aug 08 '22 16:08 kerneltime

@smengcl I think it might be ok to do this for a single change and then revert it. Making this change permanent has the potential to hurt us more than help us. Renaming existing fields without breaking wire compatibility is essential to keep code readability. I am ok with making the change, renaming, and then changing it back.

Nov 22 '22 02:11 kerneltime