ozone icon indicating copy to clipboard operation
ozone copied to clipboard

HDDS-5904. Update Recon for files created with FSO Buckets.

Open JyotinderSingh opened this issue 3 years ago • 6 comments

What changes were proposed in this pull request?

Currently, we only iterate keyTable to update Recon for keys/file stats. After the introduction of bucket types (FSO, LEGACY, OBS), Recon will not be updated for the files created with FSO buckets. Files created with FSO buckets will have intermediate directories. e.g,

Key: '/vol/fsobucket/dir1/dir2/file1'

So, it will be stored as follows in the directory table and file table:

512/dir -> Directory Table
1024/dir2 -> Directory Table
1025/file1 -> File Table

Hence in this Jira we will iterate over directory and file tables to update the Recon for files/keys created with FSO buckets.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-5904

How was this patch tested?

Related Integration Tests

JyotinderSingh avatar Feb 14 '22 11:02 JyotinderSingh

@avijayanhwx could you please review these changes?

JyotinderSingh avatar Feb 14 '22 18:02 JyotinderSingh

/pending please resolve conflict and address @avijayanhwx's comments

adoroszlai avatar Jul 25 '22 08:07 adoroszlai

Thank you very much for the patch. I am closing this PR temporarily as there was no activity recently and it is waiting for response from its author.

It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.

It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.

If you need ANY help to finish this PR, please contact the community on the mailing list or the slack channel."

github-actions[bot] avatar Aug 16 '22 00:08 github-actions[bot]

cc @smengcl should we try to get this PR to a closure? cc @GeorgeJahad you can take the commits and start a new PR if you would like to.

kerneltime avatar Sep 19 '22 16:09 kerneltime

cc @smengcl should we try to get this PR to a closure? cc @GeorgeJahad you can take the commits and start a new PR if you would like to.

Thanks for bringing this up @kerneltime and @GeorgeJahad . Please feel free to take over and rebase this PR.

smengcl avatar Sep 20 '22 16:09 smengcl

Thank you very much for the patch. I am closing this PR temporarily as there was no activity recently and it is waiting for response from its author.

It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.

It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.

If you need ANY help to finish this PR, please contact the community on the mailing list or the slack channel."

github-actions[bot] avatar Oct 12 '22 00:10 github-actions[bot]

Thank you very much for the patch. I am closing this PR temporarily as there was no activity recently and it is waiting for response from its author.

It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.

It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.

If you need ANY help to finish this PR, please contact the community on the mailing list or the slack channel."

github-actions[bot] avatar Nov 03 '22 00:11 github-actions[bot]