orc

orc copied to clipboard

Reame
Issues

ORC-1939: set TimestampColumnVector isUTC flag in TimestampFromXXXTreeReader

Open vrozov opened this issue 7 months ago • 1 comments

What changes were proposed in this pull request?

TimestampColumnVector isUTC flag should be set based on the reader useUtc flag similar to how TimestampTreeReader sets the flag based on context.getUseUTCTimestamp().

Why are the changes needed?

Correctly reflects whether TimestampColumnVector represents time in local or UTC time zones.

How was this patch tested?

Added new assertions to existing tests

Was this patch authored or co-authored using generative AI tooling?

No

Jun 24 '25 22:06 vrozov

@dongjoon-hyun Please review

Jun 24 '25 23:06 vrozov

Could you add a new minimal test case outside TestSchemaEvolution

Sorry, I don't follow. It will duplicate TestSchemaEvolution. Note that the fix only affects schema evolution use cases.

Jul 07 '25 21:07 vrozov

Since schema evolution is a tricky area, I'll keep this in main for a while.

Jul 11 '25 21:07 dongjoon-hyun

BTW, thank you, @vrozov , @wgtmac , @ffacs .

Jul 11 '25 22:07 dongjoon-hyun

I backported this to branch-2.2 for Apache ORC 2.2.0.

cc @williamhyun

Jul 25 '25 18:07 dongjoon-hyun