openwhisk icon indicating copy to clipboard operation
openwhisk copied to clipboard

Update ngrok to v3

Open style95 opened this issue 2 years ago • 1 comments

Description

Upgrade the version of ngrok to v3. It is required to run the on-demand workflow to debug CI tests.

Related issue and scope

  • [ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • [ ] API
  • [ ] Controller
  • [ ] Message Bus (e.g., Kafka)
  • [ ] Loadbalancer
  • [ ] Scheduler
  • [ ] Invoker
  • [ ] Intrinsic actions (e.g., sequences, conductors)
  • [ ] Data stores (e.g., CouchDB)
  • [ ] Tests
  • [ ] Deployment
  • [ ] CLI
  • [x] General tooling
  • [ ] Documentation

Types of changes

  • [x] Bug fix (generally a non-breaking change which closes an issue).
  • [ ] Enhancement or new feature (adds new functionality).
  • [ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • [ ] I signed an Apache CLA.
  • [ ] I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • [ ] I added tests to cover my changes.
  • [ ] My changes require further changes to the documentation.
  • [ ] I updated the documentation where necessary.

style95 avatar Feb 14 '24 22:02 style95

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (aea3a88) 76.60% compared to head (19841b0) 76.50%.

:exclamation: Current head 19841b0 differs from pull request most recent head 09921e2. Consider uploading reports for the commit 09921e2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5465      +/-   ##
==========================================
- Coverage   76.60%   76.50%   -0.11%     
==========================================
  Files         241      241              
  Lines       14650    14650              
  Branches      644      644              
==========================================
- Hits        11223    11208      -15     
- Misses       3427     3442      +15     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 14 '24 22:02 codecov-commenter