openwhisk-package-cloudant icon indicating copy to clipboard operation
openwhisk-package-cloudant copied to clipboard

Allow actions to accept db protocol as parameter

Open daisy-ycguo opened this issue 7 years ago • 4 comments

In the database-actions, https is hard coded in the source code. (see a sample here) So all database-actions cannot support databases which accept http connection only.

Adding a new parameter protocol to database-actions can resolve this issue.

daisy-ycguo avatar Aug 23 '18 09:08 daisy-ycguo

While, I also notice this package cannot manage those Cloudant db which doesn't support https connection. It has been hard coded in the action source files to use "https". We should fix this too.

daisy-ycguo avatar Aug 23 '18 09:08 daisy-ycguo

I do not follow your original comment about changesWebAction. I agree with you about the hardcoded files for the other actions. I use couchdb with http for the changes action and it works fine.

jasonpet avatar Aug 23 '18 17:08 jasonpet

@jasonpet, you are right. My original comment was wrong. changesWebAction works fine for couchdb with http. I will change the title and description to highlight the hardcoded files.

BTW, /whisk.system/cloudant/changes can accept parameter protocol, while other actions cannot. We should document this.

daisy-ycguo avatar Aug 24 '18 05:08 daisy-ycguo

@daisy-ycguo - please feel free to submit a PR to update the documentation or a fix for this

jasonpet avatar Oct 25 '18 13:10 jasonpet