opennlp icon indicating copy to clipboard operation
opennlp copied to clipboard

OPENNLP-936: Add thread-safe versions of POSTaggerME, SentenceDetecto…

Open twgoetz opened this issue 9 years ago • 4 comments

…rME and TokenizerME. Include test case as well.

I'm open to changing the names of the classes, if anybody has a better idea.

twgoetz avatar Jan 17 '17 15:01 twgoetz

Thanks!

  • Indent by 2 spaces (not 4), checkstyle is giving many warnings about that (click the green check mark to see the travis-ci output)
  • Each new file needs to have AL 2.0 license header
  • Commit messages subject line is limited to 72 chars, please make it short and also use the body of it
  • We strongly recommend to set up Eclipse or Intellij with the style files from our code convention page (https://opennlp.apache.org/code-conventions.html)
  • Update the commit above e.g. via git commit --amend or squash and then force push (git push -f) to update the PR

kottmann avatar Jan 17 '17 15:01 kottmann

Ok done.

twgoetz avatar Jan 17 '17 16:01 twgoetz

This issue (OPENNLP-936) is still relevant to many users. Is there any form of consensus - in 2022 - on how to progress with the current code base?

mawiesne avatar Oct 30 '22 19:10 mawiesne

The comments on this PR seem fairly trivial. I have no objections to getting those comments addressed and merging this. I will go through the PR again and see if there's anything since then that should be addressed.

Thanks @mawiesne for bringing attention to this one.

jzonthemtn avatar Oct 31 '22 11:10 jzonthemtn