opennlp icon indicating copy to clipboard operation
opennlp copied to clipboard

[WIP] OPENNLP-1089: Reduce printing of iterations

Open kottmann opened this issue 8 years ago • 9 comments

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

For all changes:

  • [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • [x] Has your PR been rebased against the latest commit within the target branch (typically master)?

  • [x] Is your initial contribution a single, squashed commit?

For code changes:

  • [ ] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • [ ] Have you written or updated unit tests to verify your changes?
  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • [ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

kottmann avatar Jun 08 '17 11:06 kottmann

Coverage Status

Coverage remained the same at 57.721% when pulling 0008d475192d9070266228ea5cda815690a9bcdc on kottmann:opennlp-1089 into aae0f29972d6323ad51ef18cdbc84d643a4739d8 on apache:master.

coveralls avatar Jun 08 '17 11:06 coveralls

Coverage Status

Coverage remained the same at 57.721% when pulling 0d882ab8b269fe642e097c4cac85b5a7a910cb68 on kottmann:opennlp-1089 into aae0f29972d6323ad51ef18cdbc84d643a4739d8 on apache:master.

coveralls avatar Jun 08 '17 11:06 coveralls

Coverage Status

Coverage remained the same at 57.721% when pulling 1a41452e585276b6eb4895ae1930500760c5f0c5 on kottmann:opennlp-1089 into aae0f29972d6323ad51ef18cdbc84d643a4739d8 on apache:master.

coveralls avatar Jun 08 '17 13:06 coveralls

Coverage Status

Coverage increased (+0.005%) to 57.727% when pulling 4964a8f78cddd84af43aae4e6405aa681158cf1d on kottmann:opennlp-1089 into aae0f29972d6323ad51ef18cdbc84d643a4739d8 on apache:master.

coveralls avatar Jun 08 '17 13:06 coveralls

Coverage Status

Coverage increased (+0.005%) to 57.727% when pulling 9aa34431fa52eb6f6ef3c3f6e45ce433227677bb on kottmann:opennlp-1089 into aae0f29972d6323ad51ef18cdbc84d643a4739d8 on apache:master.

coveralls avatar Jun 08 '17 13:06 coveralls

Coverage Status

Coverage increased (+0.005%) to 57.727% when pulling 6e353eb924214e3e28e99e229298d359d12ecea8 on kottmann:opennlp-1089 into aae0f29972d6323ad51ef18cdbc84d643a4739d8 on apache:master.

coveralls avatar Jun 08 '17 13:06 coveralls

Coverage Status

Coverage increased (+0.005%) to 57.728% when pulling f2813ce1871272d39802580d2a175b3cf0cebe4c on kottmann:opennlp-1089 into 8d7e1c3c5d72fda60b5db5943a6ca3d89b3de72e on apache:master.

coveralls avatar Jun 08 '17 14:06 coveralls

Coverage Status

Coverage increased (+0.005%) to 57.728% when pulling 0b7e7fb286f0a5d902fa605175ca8a65822be570 on kottmann:opennlp-1089 into 8d7e1c3c5d72fda60b5db5943a6ca3d89b3de72e on apache:master.

coveralls avatar Jun 14 '17 08:06 coveralls

Maybe it would just make more sense to set the default to false, and enable it in the places where it is needed, which are cli

kottmann avatar Jun 16 '17 12:06 kottmann

Superseded by OPENNLP-1448, thus closing this PR (and related Jira issue).

mawiesne avatar Mar 04 '23 08:03 mawiesne