Fix some build error
Summary
Fix some build error
nuttx/arch:Enabling ARCH_MATH_H is required when compiling sim with the 13.2 version of the toolchain. lib_gdbstub: fix container of bluetooth: fix bt missing header files nuttx/wqueue.h tls.h: list.h should depends on CONFIG_PTHREAD_ATFORK
Impact
CI
Testing
CI
[Experimental Bot, please feedback here]
This PR does not meet the NuttX requirements fully. Here's why and how to improve it:
What's Missing/Needs Improvement
-
Summary:
- Too Vague: "Fix some build error" is not informative enough. Be specific about what errors occurred and in which context.
- Missing Details: Briefly explain why these errors happen and how your changes address the root cause.
-
Impact:
-
CI Only? While CI impact is important, consider these:
- Functionality: Did the build errors prevent any features from working? If so, mention those features are now fixed.
- Users: Will any user workflows be affected (even if indirectly)?
- Portability: Do these fixes affect specific architectures or boards?
-
CI Only? While CI impact is important, consider these:
-
Testing:
-
CI is Not Enough: While CI passing is good, provide specific test cases you ran locally:
- What configurations did you test (boards, architectures, features enabled)?
- Ideally, include snippets of successful build logs (or error messages if relevant) before and after your changes.
-
CI is Not Enough: While CI passing is good, provide specific test cases you ran locally:
Example of an Improved Summary
Fix Build Errors Related to ARCH_MATH_H and Header File Inclusions
This PR addresses several build errors encountered when using the 13.2 toolchain:
- The
simarchitecture now requiresARCH_MATH_Hto be explicitly enabled for proper math function usage.- Missing header file inclusions in
lib_gdbstub,bluetooth, andtls.hhave been corrected to resolve compilation issues.- These errors prevented successful builds in CI and potentially impacted users of the affected components.
Additional Tips
- Link to Issues: If these build errors were reported in any NuttX issues, reference them for better context.
- Conciseness: Be clear and informative, but avoid unnecessary wordiness.
- Audience: Write for someone familiar with NuttX, but who doesn't have your specific context on the issue.
Sorry @GUIDINGLI is sim-02 failing because of this PR?
Cmake in present: sim/matter
Error: /github/workspace/sources/nuttx/build/include/libcxx/cmath:337:9: error: 'signbit' has not been declared in '::'
337 | using ::signbit _LIBCPP_USING_IF_EXISTS;
| ^~~~~~~
https://github.com/NuttX/nuttx/actions/runs/11490041505/job/31980056690#step:7:465