nuttx
nuttx copied to clipboard
samv7: fix QSPI build
Summary
Commit 313d6df7 caused the following build error:
CC: fixedmath/lib_b16atan2.c chip/sam_qspi.c: In function 'qspi_memory': chip/sam_qspi.c:1552:7: warning: implicit declaration of function 'IS_ALIGNED' [-Wimplicit-function-declaration]
1552 | IS_ALIGNED((uintptr_t)meminfo->buffer, 4) &&
| ^~~~~~~~~~
In file included from chip/sam_qspi.c:41:
chip/sam_qspi.c: In function 'qspi_alloc':
chip/sam_qspi.c:1591:21: warning: implicit declaration of function 'ALIGN_UP' [-Wimplicit-function-declaration]
1591 | return kmm_malloc(ALIGN_UP(buflen, 4));
This was caused by missing include of nuttx.h header defining ALIGN_UP and IS_ALIGNED.
Impact
Fixes samv7 build with enabled QSPI.
Testing
Build now passes, this should affect all platforms.
It seems we are missing some core peripherals in CI checks. I have a config for Xult evaluation kit that has most of the peripherals enabled, will go through it later this week (hopefully) and create one config that would test most of the SAMv7 peripherals. Then we will be able to remove some configs and reduce CI jobs, similar to this 14410.
@acassis could we merge this?