nifi icon indicating copy to clipboard operation
nifi copied to clipboard

NIFI-13872: extend manifest generation to add dependencies for proper…

Open taz1988 opened this issue 1 year ago • 2 comments

…ty descriptors in case of python processors

Summary

NIFI-13872

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • [x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-13872
  • [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-13872

Pull Request Formatting

  • [x] Pull Request based on current revision of the main branch
  • [x] Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • [x] Build completed using mvn clean install -P contrib-check
    • [x] JDK 21

Licensing

  • [ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • [ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • [ ] Documentation formatting appears as expected in rendered files

taz1988 avatar Oct 15 '24 16:10 taz1988

@taz1988 thanks for the improvement, it looks like something in the change to the python property descriptor logic is causing a system failure where it can no longer load WritePropertyToFlowFile.py in PythonProcessorIT - testFlowFileTransformWithEL.

bbende avatar Oct 15 '24 20:10 bbende

Thanks, I will investigate tomorrow, what cause the issue!

taz1988 avatar Oct 15 '24 21:10 taz1988

Fix is added, test is green locally. Somebody please kick the workflow

taz1988 avatar Nov 04 '24 11:11 taz1988

Thanks for updating @taz1988 . I'm a +1. @bbende did you have any additional concerns, or are you good to merge as well?

markap14 avatar Nov 06 '24 17:11 markap14