nifi icon indicating copy to clipboard operation
nifi copied to clipboard
verified publisher icon apache

NIFI-12880 Add processor DeleteFile

Open EndzeitBegins opened this issue 1 year ago • 4 comments

Summary

Adds new processor DeleteFile to the bundle standard-processors.

See issue NIFI-12880 for the motivation behind the addition.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • [x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • [x] Pull Request based on current revision of the main branch
  • [x] Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • [x] Build completed using mvn clean install -P contrib-check
    • [x] JDK 21

Licensing

  • [x] New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • [x] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • [x] Documentation formatting appears as expected in rendered files

EndzeitBegins avatar Mar 09 '24 15:03 EndzeitBegins

Sadly nifi-web-frontend failed. I'm not quite sure why that is but I'm certain that's not due to the changes in the PR. 🤷🏻‍♂️

Would you be so kind to start the failed jobs once more @ChrisSamo632?

EndzeitBegins avatar Mar 11 '24 16:03 EndzeitBegins

Thank you @ChrisSamo632. 👍🏻

EndzeitBegins avatar Mar 11 '24 17:03 EndzeitBegins

I've added a commit that:

  1. upon success, emits a provenance event of type REMOTE_INVOCATION
  2. upon failure, adds failure details to the FlowFile's attributes

I'd appreciate another review.

EndzeitBegins avatar Mar 14 '24 17:03 EndzeitBegins

The frontend build failed again without related changes. :( Would you be so kind to kick off the CI process once more @ChrisSamo632?

EndzeitBegins avatar Mar 16 '24 11:03 EndzeitBegins

Thank you for your feedback @exceptionfactory.

As there has been quite some work on main since I've opened the PR, I've rebased the PR on the latest commits of main. Also I added a commit that adds the @Restriction annotations as per your feedback.

EndzeitBegins avatar Jun 08 '24 10:06 EndzeitBegins