NIFI-12351 Improve MiNiFi Service Scripts for Windows

[rliszli]

Summary

NIFI-12351

This change contains the followings:
    - Apache Commons Daemon version update - Old version did not support non Oracle JDK installations. Now working with different JDK vendors and with latest Java versions as well.
    - fix missigng log file name properties, before this change there could be misleading log file names in the log directory
    - fixed install-service.bat, delete service.bat
    - Extended install service with 3 optinal parameters: serviceName, serviceUser, serviceUserPasswors
    - separated start-service and install-service
    - added stop-service.bat and stop-minifi.bat to make stopping easier 
    - updated status-minifi.bat, flowstatus-minifi.bat, and dump-minifi.bat scripts to startup properly

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• [x] Apache NiFi Jira issue created

Pull Request Tracking

• [x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

• [x] Pull Request based on current revision of the main branch
• [ ] Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• [x] Build completed using mvn clean install -P contrib-check
  • [x] JDK 21

Licensing

• [ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
• [ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• [ ] Documentation formatting appears as expected in rendered files

[bejancsaba]

@rliszli Thanks for the change, without going deeper into the code aspect could you please add some details either to the ticket or the PR or even better to the README to explain what the change addresses, what is the intended behaviour change and how it can be validated?

[exceptionfactory]

Concurring with @bejancsaba, it would be helpful to elaborate on the goal of these changes. I updated the pull request title to reflect that fact that the changes related to service scripts for MiNiFi on Windows, but it would be helpful to summarize the intended improvements.

[rliszli]

Thanks for the suggestions and for the better naming. I added a short list for this PR containing the main elements of the change. I'll also update the minifi-java-agent-quick-start.md with a more detailed instructions on how to install as a service with the new scripts.

[rliszli]

Thanks for the changes it is an area which clearly can benefit from some improvement. Maybe something is not right on my side but I'm getting the following Previously I only tested it on Windows 10. After this included Windows Server 2019 as well. Now should work on both.

[exceptionfactory]

@rliszli This seems close to completion, aside from the one merge conflict. @bejancsaba I will defer to you for further review.

[exceptionfactory]

@rliszli and @bejancsaba any updates on bringing this pull request to completion?

[rliszli]

@exceptionfactory: We still have one issue that needs to be addressed. I'll close the PR until it gets resolved.