nifi icon indicating copy to clipboard operation
nifi copied to clipboard

NIFI-10585: Add GenerateFakeRecord processor

Open mattyb149 opened this issue 3 years ago • 2 comments

Summary

NIFI-10585

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • [x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • [x] Pull Request based on current revision of the main branch
  • [x] Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • [ ] Build completed using mvn clean install -P contrib-check
    • [ ] JDK 8
    • [x] JDK 11
    • [ ] JDK 17

Licensing

  • [x] New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • [ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • [x] Documentation formatting appears as expected in rendered files

mattyb149 avatar Oct 03 '22 22:10 mattyb149

@mattyb149 will try to review soon. Have you looked at this before? https://github.com/MikeThomsen/nifi-datageneration-bundle

MikeThomsen avatar Oct 04 '22 14:10 MikeThomsen

Thanks for working on this @mattyb149! The concept looks very useful. I'm a bit concerned about the maintainability of the numerous Faker types, but in reviewing the library, I can see that it isn't necessarily easy to generalize. I would like to take a look at the library a bit more to see if there are potential opportunities to use the underlying FakeValuesService directly as opposed to the surface level strongly-typed random sources.

exceptionfactory avatar Oct 06 '22 16:10 exceptionfactory

Ah looks like I missed the property name update and your other changes look good too. thanks much!

mattyb149 avatar Dec 22 '22 22:12 mattyb149