NIFI-9514 NIFI-9515: Add UI support for Parameter Providers in Controller Services
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
This PR adds a new Parameter Providers tab in the Controller Settings UI dialog. From the Parameter Providers tab, users can add and configure Parameter Providers to fetch external parameters. Parameter contexts created from a provider will be listed in Parameter Contexts, where the parameters will be in a read-only state.
- To test, you'll need to check out and rebase on top of PR 5369.
- Links to Jiras: NIFI-9514, NIFI-9515
In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:
For all changes:
-
[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
-
[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
-
[x] Has your PR been rebased against the latest commit within the target branch (typically
main)? -
[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.
For code changes:
- [ ] Have you ensured that the full suite of tests is executed via
mvn -Pcontrib-check clean installat the rootnififolder? - [ ] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
- [ ] If applicable, have you updated the
LICENSEfile, including the mainLICENSEfile undernifi-assembly? - [ ] If applicable, have you updated the
NOTICEfile, including the mainNOTICEfile found undernifi-assembly? - [ ] If adding new Properties, have you added
.displayNamein addition to .name (programmatic access) for each of the new properties?
For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
Reviewing...
Please do not merge yet. This is still a work in progress.
This PR is now ready for review.
@mcgilman Thanks for reviewing! I addressed all of your comments.
I've also hit the issue addressed in this PR [1]. Once this PR is in, I'll try running against https://github.com/apache/nifi/pull/6388.
For this issue, I also tested my PR against PR 6388 and it works as expected.
Will you review again?