nifi-minifi-cpp icon indicating copy to clipboard operation
nifi-minifi-cpp copied to clipboard

MINIFICPP-2462 - Divide libminifi

Open adamdebreceni opened this issue 1 year ago • 1 comments

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

For all changes:

  • [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?

  • [ ] Is your initial contribution a single, squashed commit?

For code changes:

  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ ] If applicable, have you updated the LICENSE file?
  • [ ] If applicable, have you updated the NOTICE file?

For documentation related changes:

  • [ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

adamdebreceni avatar Oct 01 '24 09:10 adamdebreceni

Is there a Jira ticket associated with this PR effort? This seems like a huge refactoring contribution.

james94 avatar Oct 01 '24 15:10 james94

  • rename /core to /minifi-api, /minifi-api/include is in the include path, e.g. #include "minifi-cpp/core/FlowFile.h"
  • ProcessCpuUsageTracker, Cron shouldn't be in extension-utils

szaszm avatar Nov 25 '24 16:11 szaszm

Closing this in favor of #1902

adamdebreceni avatar Nov 27 '24 11:11 adamdebreceni