nifi-minifi-cpp icon indicating copy to clipboard operation
nifi-minifi-cpp copied to clipboard

MINIFICPP-1940 Remove unused constructor param from FlowConfiguration

Open lordgamez opened this issue 3 years ago • 3 comments

https://issues.apache.org/jira/browse/MINIFICPP-1940


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

For all changes:

  • [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?

  • [ ] Is your initial contribution a single, squashed commit?

For code changes:

  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ ] If applicable, have you updated the LICENSE file?
  • [ ] If applicable, have you updated the NOTICE file?

For documentation related changes:

  • [ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

lordgamez avatar Sep 22 '22 13:09 lordgamez

I prefer #1391 over this, but this was easier to review. I'm commenting on the JSON config PR to try to merge this into that one.

szaszm avatar Oct 05 '22 12:10 szaszm

I think if #1391 is merged, it wouldn't be that hard to resolve the conflicts in this one after a rebase.

lordgamez avatar Oct 05 '22 12:10 lordgamez

In this case, let's wait for #1391 to be merged before merging this one.

szaszm avatar Oct 05 '22 13:10 szaszm