nifi-minifi-cpp icon indicating copy to clipboard operation
nifi-minifi-cpp copied to clipboard

MINIFICPP-1846 - Json configuration support part 1

Open adamdebreceni opened this issue 3 years ago • 0 comments

:warning: To preserve you sanity during review diff the old YamlConfiguration.h to the new StructuredConfiguration.h, similarly do so for YamlConfiguration.cpp and StructuredConfiguration.cpp as git could not keep track of the lineage. Testing will happen in a separate PR as there will be some semantic changes to yaml parsing, better to keep those separate from this (mostly) syntactic change.

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

For all changes:

  • [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?

  • [ ] Is your initial contribution a single, squashed commit?

For code changes:

  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ ] If applicable, have you updated the LICENSE file?
  • [ ] If applicable, have you updated the NOTICE file?

For documentation related changes:

  • [ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

adamdebreceni avatar Aug 17 '22 09:08 adamdebreceni