netbeans icon indicating copy to clipboard operation
netbeans copied to clipboard

Exception reporter improvments

Open mbien opened this issue 3 years ago • 3 comments

We see users periodically reporting issues for old NB versions (e.g #4477 + discussion). So I wanted to see if the messaging could be a little bit improved. It turned out that the exception reporter was a little bit broken, the message didn't fit into the window and it had no scrollbars, so the user would only see part of it.

related update to website:

  • https://github.com/apache/netbeans-website/pull/603

this PR:

  • improved the messages
    • emphasized latest release requirement
    • switched text to html
    • added hyperlinks which open the issue page/log folder (having long URIs in wrapping/scrolling text is annoying)
  • wrapped TextArea of NotifyDescriptor into a ScrollPane
  • switched stack trace pane (show details) to TextArea and disabled line wrap
  • slightly larger dimensions for everything

exception-report_improved

mbien avatar Aug 09 '22 15:08 mbien

How ready is this? Because I'm tempted to say these changes are worth sneaking into NB15-rc4.

neilcsmith-net avatar Aug 12 '22 13:08 neilcsmith-net

How ready is this? Because I'm tempted to say these changes are worth sneaking into NB15-rc4.

it is basically ready. I just got the thought to maybe link "latest" to the download page (https://github.com/apache/netbeans/pull/4490#discussion_r944437999). Other than that its ready from my perspective. Should I do that?

edit: maybe we should test it on windows if the links open properly? e.g does this work:

  public static void main(String[] args) throws IOException {
        Desktop.getDesktop().browse(URI.create("file://C:\"));
  }

wait, this won't. thats not an valid URI, right? windows never disappoints.

mbien avatar Aug 12 '22 14:08 mbien

  • rebased to delivery
  • linked "latest" to download page
  • fixed URI so that it should work on windows, not planning to test it though since I don't have a win setup ready
  • added do not merge so that nobody merges accidentally except release managers

mbien avatar Aug 12 '22 15:08 mbien

Tested dialog and links on Linux and Windows. Looks good to me. Merging.

neilcsmith-net avatar Aug 16 '22 09:08 neilcsmith-net