Updade nb-javac to 19+33.
Updating nb-javac to version 19+33. This is just a temporary state (see do-not-merge badge) to check NB build and tests with the new nb-javac binary before pushing it to Maven. Will be changed to updating binaries-list later.
Obviously the binaries need distributing via Maven and the binaries-list files updating rather than deleting before this can be merged.
Is there a reason for the PR in current state? Be good to get the binaries sorted before using Travis and GitHub CI overhead for this.
This is just a temporary state (see do-not-merge badge) to check NB build and tests with the new nb-javac binary before pushing it to Maven. Will be changed to updating binaries-list later.
I assumed so - thanks for the updated description. You can use URLs in binaries-list files now too, which might be better for testing. This may or may not get properly tested now - at least discussion in #4431 might lead to this failing before it gets to any tests.
@neilcsmith-net: Changes requested are IMHO done, do you want to update your review before merge ?
i think we have to update javac again before NB 16 release, right? 19 GA is 19+36, we have 19+33 right now.