mxnet icon indicating copy to clipboard operation
mxnet copied to clipboard

[v1.x] Add recursive wildcards to Makefile

Open Kh4L opened this issue 5 years ago • 5 comments

Description

Source files and includes wildcards in the Makefile were hardcoded, limiting the depth of the globbing and making any modifications prone to forget files in make's dependency graph.

This PR adds a recursive wildcard function to be able to glob the directories recursively.

@szha

Kh4L avatar Jun 29 '20 08:06 Kh4L

Hey @Kh4L , Thanks for submitting the PR All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, sanity, windows-gpu, windows-cpu, clang, unix-gpu, miscellaneous, centos-cpu, centos-gpu, edge, unix-cpu]


Note: Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. All CI tests must pass before the PR can be merged.

mxnet-bot avatar Jun 29 '20 08:06 mxnet-bot

Following up @szha 's comment in #18630

Kh4L avatar Jun 29 '20 08:06 Kh4L

@ChaiBapchya and team is working on fixing the CI for v1.x, and we can merge this change after the CI issues are unblocked.

szha avatar Jun 29 '20 18:06 szha

@mxnet-bot run ci [all]

Kh4L avatar Sep 10 '20 00:09 Kh4L

Jenkins CI successfully triggered : [edge, clang, website, centos-gpu, centos-cpu, sanity, unix-cpu, windows-cpu, miscellaneous, windows-gpu, unix-gpu]

mxnet-bot avatar Sep 10 '20 00:09 mxnet-bot