mina icon indicating copy to clipboard operation
mina copied to clipboard

2.1.x

Open kc7bfi opened this issue 5 years ago • 2 comments

There were some places where buffers were not properly duplicated and/or freed. This caused poor performance when attempting to cache IOBuffers.

kc7bfi avatar Sep 24 '20 13:09 kc7bfi

Thanks, David !

We are reviewing the patch. Most of the time, it's not doing anything unless you are using cached buffers. I assume this is teh case for you, then the buffer aren't getting cached if they aren't freed.

elecharny avatar Sep 24 '20 14:09 elecharny

Any idea when this pull request might be accepted into the mina code base?

David R Robison Senior Systems Engineer [cid:[email protected]]

From: Emmanuel Lécharny [email protected] Sent: Thursday, September 24, 2020 10:08 AM To: apache/mina [email protected] Cc: David Robison [email protected]; Author [email protected] Subject: Re: [apache/mina] 2.1.x (#28)

Thanks, David !

We are reviewing the patch. Most of the time, it's not doing anything unless you are using cached buffers. I assume this is teh case for you, then the buffer aren't getting cached if they aren't freed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/apache/mina/pull/28#issuecomment-698368388, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAYWJXCYW66KNNT5DWVEA3DSHNHENANCNFSM4RYK2BLA.

kc7bfi avatar Nov 18 '20 14:11 kc7bfi