[MNG-7173] The maven-resolver-provider:MavenResolverModule is broken

Open cstamas opened this issue 4 years ago • 3 comments

It is broken since 3.6.2 or so, when ModelBuilder got decorated with JSR330 injections, that work in sisu but not in Guice as it needs explicit bindings added.

This is an UT that proves that module is incomplete.

Jun 14 '21 08:06 cstamas

As expected, newly added UT fails:

Error:  Errors: 
Error:    MavenResolverModuleTest.smokeTest:31 » Creation Unable to create injector, see...
[INFO] 
Error:  Tests run: 28, Failures: 0, Errors: 1, Skipped: 0

Jun 14 '21 08:06 cstamas

Related: after https://issues.apache.org/jira/browse/MNG-6685 the Guice module was not updated.

Sep 12 '21 18:09 cstamas

Test will pass, but not done yet: module is getting huge, so probably needs some refactoring, maybe splitting them into several parts (and allow overrides).

Oct 15 '21 18:10 cstamas

This PR is defunct, Guice modules were removed in https://github.com/apache/maven/pull/1282

Jan 08 '24 11:01 cstamas