maven-wrapper icon indicating copy to clipboard operation
maven-wrapper copied to clipboard

Add Arch Linux support

Open cartok opened this issue 1 year ago • 1 comments

Add Arch Linux support

On my Arch Linux, the script did not work, did not detect JAVA_HOME.

Following this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [ ] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Format the pull request title like [MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles, where you replace MWRAPPER-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [x] You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

cartok avatar Jun 03 '24 09:06 cartok

If user has already set the JAVA_HOME then this code will not take that into account. In other words, the step need to surrounded by:

if [ -z "$JAVA_HOME" ]; then

fi

Also, it may be worthwhile to explain why existing code does not work with Arch Linux. What is it that makes Arch Linux special, compared to any other Linux?

lbruun avatar May 22 '25 08:05 lbruun

This should definitely be already covered by:

https://github.com/apache/maven-wrapper/blob/88e83587f83a8b8c72d50ea419236923774b15db/maven-wrapper-distribution/src/resources/mvnw#L106-L124

Please reopen if needed.

gnodet avatar Jul 18 '25 09:07 gnodet