maven-surefire icon indicating copy to clipboard operation
maven-surefire copied to clipboard
verified publisher icon apache

Support junit-platform-runner and junit-platform-suite-engine in plugin dependencies

Open Tibor17 opened this issue 3 years ago • 1 comments

The plugin does not have a real problem with the class path as we expected in the Jira issue SUREFIRE-2000. I found this PR as an improvement where the junit-platform-runner can be in the plugin dependencies. The previous implementation expected junit-platform-runner only in the project dependencies. Additionally, we added junit-platform-suite-engine as a successor of junit-platform-runner in the documentation and IT.

Following this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [x] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles, where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [x] You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

Tibor17 avatar Mar 05 '22 20:03 Tibor17

@slawekjaranowski done

Tibor17 avatar Mar 05 '22 21:03 Tibor17