maven-pmd-plugin icon indicating copy to clipboard operation
maven-pmd-plugin copied to clipboard
verified publisher icon apache

[MPMD-395] Build doesn't fail for invalid CPD format

Open adangel opened this issue 1 year ago • 1 comments

https://issues.apache.org/jira/browse/MPMD-395

Refs https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094372771

Following this checklist to help us incorporate your contribution quickly and easily:

  • [x] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [x] Each commit in the pull request should have a meaningful subject line and body.
  • [x] Format the pull request title like [MPMD-XXX] - Subject of the JIRA Ticket, where you replace MPMD-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [x] You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

adangel avatar May 10 '24 08:05 adangel

Will try to review in the next couple of days.

michael-o avatar May 10 '24 15:05 michael-o

@adangel Do you think you could add a test which invokes the exception handling and we can see the log output and throw combined?

michael-o avatar Jun 03 '24 13:06 michael-o

@adangel thanks for the rework, will review again.

michael-o avatar Jun 06 '24 08:06 michael-o

Thank you as well!

I will take care of the next release.

Just for this fix I don't think a new release is needed immediately. It's sufficient, if this lands in the next release whenever it happens.

adangel avatar Jun 07 '24 07:06 adangel

Thank you as well!

I will take care of the next release.

Just for this fix I don't think a new release is needed immediately. It's sufficient, if this lands in the next release whenever it happens.

True, swallowing exceptions is not good and I need to bump to Maven 3.6.3 anyway.

michael-o avatar Jun 07 '24 07:06 michael-o