maven-plugin-testing icon indicating copy to clipboard operation
maven-plugin-testing copied to clipboard

[WIP] [MPLUGINTESTING-93] - Prepare documentation / examples for JUnit 5 and Maven 3

Open aamotharald opened this issue 1 year ago • 2 comments

starting some documentation activities now and performing testing of the JUnit5 maven-plugin testing capabilities with existing open source maven plugins.

@gnodet I have made a small change in the MojoExtension as I think it's valid to have no configuration for your maven plugin at all. I'll just take the commit away if my understanding here is wrong

aamotharald avatar Dec 13 '24 08:12 aamotharald

This is really interesting. I'd like to see some changes from https://github.com/apache/maven-plugin-testing/commit/c6ef221ab068ee487e1c535aa2b8925ecc4f0db6 back ported to make the annotations identical (the @Inherited and the changes in InjectMojo). Maybe also the new @Basedir annotation ?

gnodet avatar Jan 07 '25 08:01 gnodet

Hi @gnodet , I have been able to to make the Annotations identical (added @Inherited and removed the boolean flag from InjectMojo). I was also able to backport the @Basedir Annotation and added a unit test for that behaviour.

So what's left open is the stubbing. I made a check and backporting all the stubs seems to be a bigger task. My current opinion is to NOT offer the stubs on maven 3 (which means maven-plugin-testing with stubs is only possible with old JUnit 4 style tests extending the AbstractMojoTestCase). What is your opinion there?

aamotharald avatar Jan 09 '25 08:01 aamotharald

Resolve #192

jira-importer avatar Jul 16 '25 07:07 jira-importer

@aamotharald Same here :)

Bukama avatar Aug 03 '25 07:08 Bukama

@gnodet @slachiewicz @aamotharald I have rebased and fix build

I hope we can process it forward

slawekjaranowski avatar Oct 12 '25 16:10 slawekjaranowski

@gnodet @slachiewicz look ok for me .... I would like to process it

I will change PR title as we improve JUnit 5 implementation, documentation will be fixed in next PR

@aamotharald thanks for work

slawekjaranowski avatar Oct 14 '25 16:10 slawekjaranowski