maven-jlink-plugin icon indicating copy to clipboard operation
maven-jlink-plugin copied to clipboard

[#620] Add support for optional attach parameter to disable artifact attachment

Open peter277 opened this issue 6 months ago • 4 comments

Add support for optional attach parameter to disable artifact attachment

fixes #620

Checklist

  • [x] Make sure there is a GitHub issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • [x] Each commit in the pull request should have a meaningful subject line and body.
  • [x] Format the pull request title like [#<num>] - Fixes bug in ApproximateQuantiles, where you replace #<num> with the appropriate GitHub issue. Best practice is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [x] You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

peter277 avatar Jul 19 '25 08:07 peter277

simple test will be appreciated

I have added a new integration test attach_skip to this pull request to test the new parameter's behaviour. Would appreciate your review.

peter277 avatar Jul 20 '25 08:07 peter277

Hi Team - just checking in to see if there’s anything I can do to help move this PR forward? Happy to make adjustments if needed.

CC: @slawekjaranowski, @bmarwell

peter277 avatar Sep 28 '25 04:09 peter277

Thanks @bmarwell for the review - I have incorporated your suggested changes into the branch.

peter277 avatar Sep 29 '25 06:09 peter277

Hi Team - just checking in to see if there’s anything else needed before this PR can be merged? Do I need to sign an individual contributor license agreement, given that the change only adds a flag?

Was hoping there might be a release in the near future including this change so that I could start using it.

peter277 avatar Oct 20 '25 11:10 peter277