maven-compiler-plugin icon indicating copy to clipboard operation
maven-compiler-plugin copied to clipboard

[MCOMPILER-540] useIncrementalCompilation=false may add generated sources to the sources list

Open mensinda opened this issue 2 years ago • 4 comments

See MCOMPILER-540.

This PR fixes the bug by filtering out the generated sources from the stale sources list.


Following this checklist to help us incorporate your contribution quickly and easily:

  • [x] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [x] Each commit in the pull request should have a meaningful subject line and body.
  • [x] Format the pull request title like [MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles, where you replace MCOMPILER-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [x] You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

mensinda avatar Jun 16 '23 12:06 mensinda

This could use a test that exposes the bug.

why not merge

yanye666 avatar May 22 '24 01:05 yanye666

As requested, I have added a test case.

NOTE: The added test case will only pass once #191 is merged, or MCOMPILER-538 is fixed another way.

mensinda avatar Nov 04 '24 14:11 mensinda

Hmm, why didn't the CI run? I need to figure out how to trigger that

elharo avatar Feb 17 '25 22:02 elharo

Rabased, and the CI should pass now since #191 is merged.

mensinda avatar Mar 10 '25 16:03 mensinda