maven-checkstyle-plugin icon indicating copy to clipboard operation
maven-checkstyle-plugin copied to clipboard

[MCHECKSTYLE-397] support ${config_loc} on checkstyle xml

Open qxo opened this issue 5 years ago • 3 comments

we can use config_loc as: ${config_loc}/suppressions.xml.

with this PR, we can use same checkstyle.xml which contains ${config_loc}

for eclipsecs ${config_loc} is a variable of Eclipse and it will refer to the same directory where the checkstyle.xml is present. ref: https://checkstyle.org/eclipse-cs/#!/properties

https://issues.apache.org/jira/projects/MCHECKSTYLE/issues/MCHECKSTYLE-397

Following this checklist to help us incorporate your contribution quickly and easily:

  • [x] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [x] Each commit in the pull request should have a meaningful subject line and body.
  • [x] Format the pull request title like [MCHECKSTYLE-XXX] - Fixes bug in ApproximateQuantiles, where you replace MCHECKSTYLE-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [ ] You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

qxo avatar Sep 19 '20 01:09 qxo

mvn -Prun-its clean verify failed on my PC because my network issue:

javax.net.ssl.SSLException: Connection reset
    at sun.security.ssl.Alert.createSSLException (Alert.java:127)
    at sun.security.ssl.TransportContext.fatal (TransportContext.java:321)
    at sun.security.ssl.TransportContext.fatal (TransportContext.java:264)
    at sun.security.ssl.TransportContext.fatal (TransportContext.java:259)
    at sun.security.ssl.SSLTransport.decode (SSLTransport.java:137)
    at sun.security.ssl.SSLSocketImpl.decode (SSLSocketImpl.java:1152)

qxo avatar Sep 19 '20 01:09 qxo

@bmarwell @elharo it's really a nice feature to have in the plug-in. Currently enabling suppressions for a Maven multi-module project is much more complex than it could be. ${config_loc} support should enable seamless experience for Checkstyle users.

So could I for example continue work on this feature if it has chances for merge? As I understand this pull request remarks should be solved?

lrozenblyum avatar Jul 22 '22 12:07 lrozenblyum