logging-flume icon indicating copy to clipboard operation
logging-flume copied to clipboard
verified publisher icon apache

Read header and footer if available

Open sebastian-alfers opened this issue 9 years ago • 9 comments

This commit fixes an issue, that header-values can not be restored correctly after an event was avro-serialized to disk.

The problem was, that deserializing the event from disk, the body of the event contained the binary and the header.

See: https://issues.apache.org/jira/browse/FLUME-2942

Discussion welcome!

sebastian-alfers avatar Dec 21 '16 08:12 sebastian-alfers

@adenes Thanks fore your comments, I updated the pr

sebastian-alfers avatar Jan 04 '17 15:01 sebastian-alfers

@adenes any comments?

sebastian-alfers avatar Jan 10 '17 08:01 sebastian-alfers

@adenes ping

sebastian-alfers avatar Jan 17 '17 15:01 sebastian-alfers

@laxman-ch @adenes @simonati anyone likes to push this PR forward? Comments welcome

sebastian-alfers avatar Feb 14 '17 09:02 sebastian-alfers

Thanks for the heads up! Let me take a look today.

simonati avatar Feb 14 '17 10:02 simonati

Hi @sebastian-alfers,

This change is quite big and hard to follow. Please give me more time to finish the review or help any other reviewer by making consumption of your changes easier by leaving some more hints about the ideas behind your changes.

simonati avatar Feb 20 '17 18:02 simonati

@simonati Thanks for you comment. Actually, I wrote down all my ideas in the corresponding jira ticket. If you have any particular question feel free to point them out

sebastian-alfers avatar Feb 20 '17 22:02 sebastian-alfers

Push

sebastian-alfers avatar Mar 15 '17 14:03 sebastian-alfers

Can one of the admins verify this patch?

asfgit avatar Aug 17 '18 13:08 asfgit