FLUME-2980 : Automated concurrent Kafka offset migration test

[umesh9794]

[umesh9794]

Tests are passing locally on trunk :

Command: mvn -DfailIfNoTests=false -Dtest=org.apache.flume.channel.kafka.TestKafkaChannel#testAutomaticOffsetsMigration clean test

Running org.apache.flume.channel.kafka.TestKafkaChannel Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 90.408 sec

Results : Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 02:28 min [INFO] Finished at: 2016-11-29T20:01:25+05:30 [INFO] Final Memory: 523M/1982M [INFO] ------------------------------------------------------------------------

[harishreedharan]

The tests pass fine, but there are checkstyle violations causing the build to fail:

[ERROR] src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java:[900,18] (whitespace) WhitespaceAround: WhitespaceAround: '=' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)
[ERROR] src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java:[901,57] (whitespace) WhitespaceAround: WhitespaceAround: '=' is not preceded with whitespace.
[ERROR] src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java:[901,58] (whitespace) WhitespaceAround: WhitespaceAround: '=' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)
[ERROR] src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java:[910] (sizes) LineLength: Line is longer than 100 characters (found 135).
[ERROR] src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java:[920,18] (whitespace) WhitespaceAround: WhitespaceAround: '=' is not preceded with whitespace.
[ERROR] src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java:[920,19] (whitespace) WhitespaceAround: WhitespaceAround: '=' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)
[ERROR] src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java:[925] (sizes) LineLength: Line is longer than 100 characters (found 119).
[ERROR] src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java:[927] (sizes) LineLength: Line is longer than 100 characters (found 127).
[ERROR] src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java:[931,18] (whitespace) WhitespaceAround: WhitespaceAround: '=' is not preceded with whitespace.
[ERROR] src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java:[931,19] (whitespace) WhitespaceAround: WhitespaceAround: '=' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)
[ERROR] src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java:[932] (sizes) LineLength: Line is longer than 100 characters (found 133).
[ERROR] src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java:[936] (sizes) LineLength: Line is longer than 100 characters (found 114).
[ERROR] src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java:[953,17] (whitespace) WhitespaceAround: WhitespaceAround: '=' is not preceded with whitespace.
[ERROR] src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java:[953,18] (whitespace) WhitespaceAround: WhitespaceAround: '=' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)```

Those need to be fixed.

[umesh9794]

Thanks @harishreedharan for your comment. Actually in the committed TestKafkaChannel.java file there are no such violations which are pointed by Travis. May I request you to verify the first one at least, which is for 900 line and 18 column?

[umesh9794]

Thanks @simonati for pointing the checkstyle issues. Please review the updated commit.

[asfgit]

Can one of the admins verify this patch?