[KYUUBI #6084] JDBC driver supports configuration not to pull engine startup logs
:mag: Description
Issue References ๐
This pull request fixes #6084
Describe Your Solution ๐ง
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Support --ignore-launch-engine option and not pull engine starup logs
Types of changes :bookmark:
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Test Plan ๐งช
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests
Checklist ๐
- [ ] This patch was not authored or co-authored using Generative Tooling
Be nice. Be informative.
is it for security purposes? if so, maybe we should disable the log on the server side?
Codecov Report
Attention: Patch coverage is 86.66667% with 2 lines in your changes are missing coverage. Please review.
Project coverage is 62.25%. Comparing base (
2c9fb3d) to head (a9c08ad). Report is 35 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| .../org/apache/kyuubi/jdbc/hive/KyuubiConnection.java | 33.33% | 0 Missing and 2 partials :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #6106 +/- ##
============================================
+ Coverage 61.12% 62.25% +1.13%
- Complexity 23 24 +1
============================================
Files 623 625 +2
Lines 37200 38982 +1782
Branches 5040 5333 +293
============================================
+ Hits 22738 24269 +1531
- Misses 12001 12245 +244
- Partials 2461 2468 +7
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
is it for security purposes?
We just want to align hive's native beeline behavior and reduce some logs and RPC.
beeline has a --verbose option, seems we do not respect it though
Can we skip the creation of engine-launch-log thread created byKyuubiConnection#showLaunchEngineLog if ignoreLaunchEngineLog is true ?