kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

[KYUUBI #4656] client open session with original engineRefId

Open lightning-L opened this issue 2 years ago • 4 comments

Why are the changes needed?

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [ ] Run test locally before make a pull request

lightning-L avatar Apr 04 '23 10:04 lightning-L

@turboFei

lightning-L avatar Apr 04 '23 10:04 lightning-L

Codecov Report

Merging #4665 (a2abbde) into master (061545b) will decrease coverage by 0.05%. The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master    #4665      +/-   ##
============================================
- Coverage     57.58%   57.54%   -0.05%     
  Complexity       13       13              
============================================
  Files           579      579              
  Lines         31964    31966       +2     
  Branches       4269     4270       +1     
============================================
- Hits          18408    18396      -12     
- Misses        11789    11802      +13     
- Partials       1767     1768       +1     
Impacted Files Coverage Δ
.../org/apache/kyuubi/config/KyuubiReservedKeys.scala 0.00% <ø> (ø)
.../org/apache/kyuubi/jdbc/hive/KyuubiConnection.java 47.25% <0.00%> (-0.44%) :arrow_down:
.../org/apache/kyuubi/session/KyuubiSessionImpl.scala 79.72% <100.00%> (ø)

... and 8 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Apr 04 '23 14:04 codecov-commenter

It is better to reconnect the session automatically.

turboFei avatar Apr 12 '23 07:04 turboFei

this comment need to be addressed.

https://github.com/apache/kyuubi/pull/4545#issuecomment-1478931310

turboFei avatar Apr 12 '23 07:04 turboFei