kyuubi icon indicating copy to clipboard operation
kyuubi copied to clipboard

[KYUUBI #3529] Add tests to check for consistency with V1 in hive connector

Open yikf opened this issue 3 years ago • 1 comments

Why are the changes needed?

Fix https://github.com/apache/incubator-kyuubi/issues/3529

Add tests to check for consistency with V1

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [x] Run test locally before make a pull request

yikf avatar Sep 20 '22 11:09 yikf

Could you please take a look when you have a time, thans @pan3793

yikf avatar Sep 20 '22 13:09 yikf

We may need to extend or build a test framework like SPARK-33382

pan3793 avatar Sep 30 '22 05:09 pan3793

Codecov Report

Merging #3530 (cfbef99) into master (73612b7) will decrease coverage by 0.01%. The diff coverage is n/a.

:exclamation: Current head cfbef99 differs from pull request most recent head d0af076. Consider uploading reports for the commit d0af076 to get more accurate results

@@             Coverage Diff              @@
##             master    #3530      +/-   ##
============================================
- Coverage     51.67%   51.65%   -0.02%     
  Complexity       13       13              
============================================
  Files           482      482              
  Lines         26933    26933              
  Branches       3760     3760              
============================================
- Hits          13917    13912       -5     
- Misses        11661    11665       +4     
- Partials       1355     1356       +1     
Impacted Files Coverage Δ
...apache/kyuubi/engine/JpsApplicationOperation.scala 77.41% <0.00%> (-3.23%) :arrow_down:
...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala 78.00% <0.00%> (-2.00%) :arrow_down:
...che/kyuubi/server/KyuubiTHttpFrontendService.scala 64.23% <0.00%> (-0.73%) :arrow_down:
...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala 80.74% <0.00%> (-0.63%) :arrow_down:
...in/scala/org/apache/kyuubi/config/KyuubiConf.scala 97.23% <0.00%> (-0.08%) :arrow_down:
...g/apache/kyuubi/operation/BatchJobSubmission.scala 74.64% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Oct 09 '22 10:10 codecov-commenter

Thanks, merging to master

pan3793 avatar Oct 15 '22 14:10 pan3793