apache
[Bug] Throw the exception to notify FlinkEngine config `table.dml-sync` is not equal to the parameter runAsync
Code of Conduct
- [X] I agree to follow this project's Code of Conduct
Search before asking
- [x] I have searched in the issues and found no similar issues.
Describe the bug
Flink table uses table.dml-sync[1] to control whether wait the execution finish. However, Kyuubi use its own parameter to control the behaviour. I think it's neccesary to keep the behaviour unified and throw the exception to notify the users.
[1] https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/config/#table-dml-sync
Affects Version(s)
master
Kyuubi Server Log Output
No response
Kyuubi Engine Log Output
No response
Kyuubi Server Configurations
No response
Kyuubi Engine Configurations
No response
Additional context
No response
Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
Hello @fsk119, Thanks for finding the time to report the issue! We really appreciate the community's efforts to improve Apache Kyuubi (Incubating).
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi, all. Sorry for the late response. I think it's not a bug after reconsider the issue. The option table.dml-sync means the Flink TableEnvironment will wait for the execution finish, which means the lifecycle of the Operation contains the job execution. But the sync mode in the gateway means the Gateway should return the signal to the client until the Operation finishes, which doesn't means the gateway should influence the lifecycle of the Operation. Therefore, I think the two options don't need be the same. WDYT?
But the Operation lifecycle in the Hive always contains the execution of the job[1], right? Maybe we should set the option true forcely?
[1]https://github.com/apache/hive/blob/23b0d30051af3ade5b03496ab9cf22929168dc84/service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java#L233
