kvrocks icon indicating copy to clipboard operation
kvrocks copied to clipboard

feat(stream): add support of XPENDING command

Open Yangsx-1 opened this issue 1 year ago • 3 comments

Close #1734

Yangsx-1 avatar Jun 30 '24 12:06 Yangsx-1

LGTM. Ideally, it would be great to add the test case for the filtering by IDLE time.

Will add it in another PR. :)

Yangsx-1 avatar Jul 01 '24 05:07 Yangsx-1

After https://github.com/apache/kvrocks/pull/2384, I think this command need to be refactored.

So it's better to review and merge #2384 before this PR.

PragmaTwice avatar Jul 01 '24 05:07 PragmaTwice

https://github.com/apache/kvrocks/pull/2384 is merged, could you refactor this PR to avoid iterating the whole stream subkeys?

PragmaTwice avatar Jul 17 '24 04:07 PragmaTwice

#2384 is merged, could you refactor this PR to avoid iterating the whole stream subkeys?

Sure, will do it later.

Yangsx-1 avatar Jul 17 '24 09:07 Yangsx-1