kvrocks Add the support of the LCS command

Close #1955

Feb 25 '24 15:02 JoverZhang

Can someone confirm whether this logic is correct? I am also unable to determine it. Alternatively, can we ignore whether the algorithm is correct and fix it when a bug arises?

Feb 27 '24 13:02 jihuayu

As mentioned by @jihuayu, the implementation of the algorithm should be put into redis_string.cc instead of cmd_string.cc.

Understood, I have moved the algorithm to redis_string.cc as suggested. Please review the implementation and let me know if any further modifications are required.

Feb 29 '24 02:02 JoverZhang

Quality Gate failed

Failed conditions
9.4% Duplication on New Code (required ≤ 5%)

See analysis details on SonarCloud

Mar 03 '24 11:03 sonarqubecloud[bot]

Thank you for your contribution!

Mar 03 '24 12:03 PragmaTwice

Hi @JoverZhang, can you add this command to our docs? You can set Since Version with unstable. https://kvrocks.apache.org/docs/supported-commands#string-commands

Mar 03 '24 12:03 jihuayu

Hi @JoverZhang, can you add this command to our docs? You can set Since Version with unstable. https://kvrocks.apache.org/docs/supported-commands#string-commands

Okay, I added it. https://github.com/apache/kvrocks-website/pull/208

Mar 10 '24 14:03 JoverZhang