apache
[KARAF-7423] Add logback configuration option
I've added an xml based configuration service implementation for logback configurations and corresponding unittests and documentation.
Are we sure we want logback by default ? I would rather prefer to keep log4j2 style by default, and document how to have logback instead. Or eventually create another framework/static feature (with logback classifier for instance) to easily use logback.
Thoughts ?
Are we sure we want logback by default ? I would rather prefer to keep log4j2 style by default, and document how to have logback instead. Or eventually create another framework/static feature (with logback classifier for instance) to easily use logback.
Thoughts ?
The default option is still log4j2. The logback service just also exists now and can be included if needed.
I understand the confusion. I made a mistake in including pax-logging-logback in the wrong place in assembly I'll remove it and update my pull request The framework/static feature mentioned exists. That's why I shouldn't have included it in default
Using the configuration adaptation internally revealed a bug, where logger creation could not work if the last element of the configuration xml had child elements. This is now fixed
@jbonofre: last time I checked myself, I was able to build & run all tests successfully on my local machine. The last tests run here @GitHub seemed to fail due to infrastructure isues (SSH timeouts if I remember correctly). Another run requested by @i-thiemann this week is just hanging around. Could you please support here? We are pretty interested to see full (optional) Logback support in Karaf, therefore we implemented and contributed that ourself. Thanks!
If you don't mind, I will squash the 5 commits in a single one.
That would be fine.