KAFKA-14589 [2/3] Tests of ConsoleGroupCommand rewritten in java
This PR is part of #14471
Is contains some of ConsoleGroupCommand tests rewritten in java.
Intention of separate PR is to reduce changes and simplify review.
Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
Hello @showuon
Can you, please, take a look? I've checked CI results and it seems OK for me.
Hello @mimaison @jolshan Can you, please, take a look?
Hello @showuon @jolshan @mimaison
Can you, please, take a look?
Hello, @rreddy-22 @dajac
Can you, please, take a look at these changes?
It PR moves DescribeConsumerGroupTest and ResetConsumerGroupOffsetTest as part of moving ConsoleGroupCommand to tools.
Having it in trunk will reduce your work while improving ConsoleGroupCommand (no need to duplicate test changes in java and scala) and help moving command to tools.
Big PR where all command code rewritten in java - #14471
Right now, changes in ConsoleGroupCommand leads to conflicts in my PR which is hard to resolve.
Hello @chia7712
Please, take a look. If this patch to big to review I can split it to two.
WDYT?
If this patch to big to review I can split it to two.
please :)
@chia7712 Done.
@chia7712
Other PR is #15465
Seems, PR's are reviewable now. Please, take a look.
@chia7712 This PR ready for review.
Please, take a look.
@chia7712 Thanks for the review. All your comments fixed. Please, take a look one more time.
the failed tests pass on my machine.
./gradlew cleanTest core:test --tests ReplicaManagerTest --tests LogDirFailureTest
will merge it
@nizhikov thanks for this nice patch
@chia7712 Thanks for the review and merge!