kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-14589 [2/3] Tests of ConsoleGroupCommand rewritten in java

Open nizhikov opened this issue 2 years ago • 3 comments

This PR is part of #14471 Is contains some of ConsoleGroupCommand tests rewritten in java. Intention of separate PR is to reduce changes and simplify review.

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

nizhikov avatar Feb 13 '24 14:02 nizhikov

Hello @showuon

Can you, please, take a look? I've checked CI results and it seems OK for me.

nizhikov avatar Feb 14 '24 15:02 nizhikov

Hello @mimaison @jolshan Can you, please, take a look?

nizhikov avatar Feb 15 '24 10:02 nizhikov

Hello @showuon @jolshan @mimaison

Can you, please, take a look?

nizhikov avatar Feb 26 '24 07:02 nizhikov

Hello, @rreddy-22 @dajac

Can you, please, take a look at these changes? It PR moves DescribeConsumerGroupTest and ResetConsumerGroupOffsetTest as part of moving ConsoleGroupCommand to tools.

Having it in trunk will reduce your work while improving ConsoleGroupCommand (no need to duplicate test changes in java and scala) and help moving command to tools.

Big PR where all command code rewritten in java - #14471

Right now, changes in ConsoleGroupCommand leads to conflicts in my PR which is hard to resolve.

nizhikov avatar Feb 29 '24 12:02 nizhikov

Hello @chia7712

Please, take a look. If this patch to big to review I can split it to two.

WDYT?

nizhikov avatar Mar 04 '24 14:03 nizhikov

If this patch to big to review I can split it to two.

please :)

chia7712 avatar Mar 04 '24 14:03 chia7712

@chia7712 Done.

nizhikov avatar Mar 04 '24 14:03 nizhikov

@chia7712

Other PR is #15465

Seems, PR's are reviewable now. Please, take a look.

nizhikov avatar Mar 04 '24 15:03 nizhikov

@chia7712 This PR ready for review.

Please, take a look.

nizhikov avatar Mar 06 '24 09:03 nizhikov

@chia7712 Thanks for the review. All your comments fixed. Please, take a look one more time.

nizhikov avatar Mar 06 '24 17:03 nizhikov

the failed tests pass on my machine.

./gradlew cleanTest core:test --tests ReplicaManagerTest --tests LogDirFailureTest

will merge it

chia7712 avatar Mar 06 '24 23:03 chia7712

@nizhikov thanks for this nice patch

chia7712 avatar Mar 06 '24 23:03 chia7712

@chia7712 Thanks for the review and merge!

nizhikov avatar Mar 07 '24 08:03 nizhikov