kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-14239: Merge StateRestorationIntegrationTest into RestoreIntegrationTest

Open ahmedsobeh opened this issue 3 years ago • 3 comments

This PR makes the following changes:

  • Moves the only test in StateRestorationIntegrationTest into RestoreIntegrationTest
  • Deletes StateRestorationIntegrationTest

ahmedsobeh avatar Sep 21 '22 14:09 ahmedsobeh

Thanks @ahmedsobeh ! Will take a look.

guozhangwang avatar Sep 22 '22 22:09 guozhangwang

Thanks @ahmedsobeh ! Will take a look.

had a small import issue that I just fixed, should be good now.

ahmedsobeh avatar Sep 22 '22 23:09 ahmedsobeh

There's still jenkins failures:

[2022-09-23T00:16:58.037Z] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-12670/streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java:161:22: Name 'APPLICATION_ID' must match pattern '^[a-z][a-zA-Z0-9]*$'. [LocalFinalVariableName]

[2022-09-23T00:16:58.037Z] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-12670/streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java:162:22: Name 'STATE_STORE_NAME' must match pattern '^[a-z][a-zA-Z0-9]*$'. [LocalFinalVariableName]

[2022-09-23T00:16:58.037Z] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-12670/streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java:163:22: Name 'INPUT_TOPIC' must match pattern '^[a-z][a-zA-Z0-9]*$'. [LocalFinalVariableName]

[2022-09-23T00:16:58.037Z] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-12670/streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java:164:22: Name 'OUTPUT_TOPIC' must match pattern '^[a-z][a-zA-Z0-9]*$'. [LocalFinalVariableName]

[2022-09-23T00:16:58.037Z] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-12670/streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java:168:20: Variable 'streamsConfiguration' should be declared final. [FinalLocalVariable]

guozhangwang avatar Sep 23 '22 02:09 guozhangwang