kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-13908 Rethrow ExecutionException to preserve original cause

Open nizhikov opened this issue 3 years ago • 1 comments

Rethrow ExecutionException instead of wrapping it in RuntimeException. It will preserve original cause in method-wide catch block:

    } catch {
      case e: Throwable =>
        maybeChangeStatus(STARTING, STARTED)
        fatal("Fatal error during broker startup. Prepare to shutdown", e)
        shutdown()
        throw if (e.isInstanceOf[ExecutionException]) e.getCause else e
    }

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

nizhikov avatar Aug 31 '22 07:08 nizhikov

Hello @showuon.

Can you, please, take a look at my changes?

nizhikov avatar Sep 01 '22 08:09 nizhikov