kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-10199: Handle task closure and recycling from state updater

Open guozhangwang opened this issue 3 years ago • 1 comments

  1. Within the tryCompleteRestore function of the thread, try to drain the removed tasks from state updater and handle accordingly: 1) for recycle, 2) for closure, 3) for update input partitions.
  2. Catch up on some unit test coverage from previous PRs.
  3. Some minor cleanups.

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

guozhangwang avatar Aug 01 '22 17:08 guozhangwang

In Tasks on line 141 and line 163 why do we not verify that the task ID is contained in map and throw an IllegalStateException if not as we do for standbyTasksPerId? In the end those tasks are owned by the task.

Following your other comment, I've removed these two lines.

guozhangwang avatar Aug 11 '22 00:08 guozhangwang

Merged to trunk, @cadonna please feel free to leave more comments, and I will address in https://github.com/apache/kafka/pull/12519

guozhangwang avatar Aug 16 '22 02:08 guozhangwang