kafka icon indicating copy to clipboard operation
kafka copied to clipboard
verified publisher icon apache

KAFKA-13414: Replace PowerMock/EasyMock with Mockito in connect.storage.KafkaOffsetBackingStoreTest

Open clolov opened this issue 3 years ago • 2 comments

Partially addressing https://issues.apache.org/jira/browse/KAFKA-13414. Other test files will be updated in other pull requests.

clolov avatar Jul 18 '22 15:07 clolov

@mimaison I believe you might be best suited to review this pull request :)

clolov avatar Jul 18 '22 16:07 clolov

Thank you for the review @C0urante! I will have a look and aim to provide answers (+ new commits) in the next couple of days.

clolov avatar Aug 03 '22 16:08 clolov

@clolov are you planning on revisiting this one?

C0urante avatar Nov 07 '22 15:11 C0urante

Hello, yes I am, it is the next one on my list :)

clolov avatar Nov 07 '22 16:11 clolov

Thank you for the new comments @C0urante, I will aim to address them today!

clolov avatar Nov 15 '22 11:11 clolov

The single test failure is unrelated; merging...

C0urante avatar Nov 15 '22 21:11 C0urante

Thank you for the quick turnaround on the review @C0urante! I will aim to open a couple more pull requests in the upcoming days for Connect with respect to the Mockito migration and tag you there.

clolov avatar Nov 16 '22 10:11 clolov