jmeter icon indicating copy to clipboard operation
jmeter copied to clipboard

Update grgit to 4.1.1 (from 4.1.0)

Open SampathKumarAmex opened this issue 4 years ago • 4 comments

Description

Upgrading the plugin to latest version which is available in maven central. Please see the notes here.

Motivation and Context

I was unable to build the code as the grgit dependency couldn't be pulled from JCenter. Looks like the old versions are moved to bintray-backup. So, it make sense to move to the latest version (patch upgrade) which is available in maven central. Please refer this link for more details.

How Has This Been Tested?

n/a - Build issue

Screenshots (if appropriate):

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [X] My code follows the code style of this project.
  • [ ] I have updated the documentation accordingly.

SampathKumarAmex avatar Jan 12 '22 18:01 SampathKumarAmex

Codecov Report

Merging #691 (e91820a) into master (af7fc4d) will increase coverage by 0.00%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #691   +/-   ##
=========================================
  Coverage     55.59%   55.59%           
  Complexity    10336    10336           
=========================================
  Files          1059     1059           
  Lines         65045    65050    +5     
  Branches       7399     7401    +2     
=========================================
+ Hits          36160    36163    +3     
- Misses        26336    26337    +1     
- Partials       2549     2550    +1     
Impacted Files Coverage Δ
...n/java/org/apache/jmeter/reporters/Summariser.java 90.07% <0.00%> (-0.77%) :arrow_down:
...rg/apache/jmeter/assertions/JSONPathAssertion.java 80.85% <0.00%> (-0.05%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af7fc4d...e91820a. Read the comment docs.

codecov-commenter avatar Jan 12 '22 19:01 codecov-commenter

@SampathKumarAmex , would you please squash the commits? Unfortunately, GitHub's "squash and merge" can't be used as it loses history.

vlsi avatar Jan 19 '22 13:01 vlsi

@SampathKumarAmex , would you please squash the commits? Unfortunately, GitHub's "squash and merge" can't be used as it loses history.

Done.

SampathKumarAmex avatar Jan 26 '22 16:01 SampathKumarAmex

For reference, grgit-gradle 5.0.0 is Java 11+

vlsi avatar Feb 21 '22 10:02 vlsi