Let's have Plugins Manager added in JMeter by default

[asfimport]

Sebastian Boga (Bug 63459): There are some plugins that are very useful for our work as JMeter testers. We should put the Plugins Manager by default in JMeter main product. How to have Plugins Manager in JMeter it's described here: https://jmeter-plugins.org/install/Install/

It's just a matter of having a JAR file in ext\lib. The plugins-manager.jar file is public and available to anyone.

Let's avoid doing this manually everytime a new version of JMeter is released.

Votes in Bugzilla: 1 OS: All

[asfimport]

@pmouawad (migrated from Bugzilla): (In reply to Sebastian Boga from comment 0)

There are some plugins that are very useful for our work as JMeter testers. We should put the Plugins Manager by default in JMeter main product. How to have Plugins Manager in JMeter it's described here: https://jmeter-plugins.org/install/Install/

It's just a matter of having a JAR file in ext\lib. The plugins-manager.jar file is public and available to anyone.

Let's avoid doing this manually everytime a new version of JMeter is released.

Unless JMeter-Plugins project contributes it to our projects, that's not something we can do.

You can ask there if they would be ok.

Closing for now, will reopen if that can happen.

Regards

[asfimport]

orimarko (migrated from Bugzilla): Plugins Manager is a extension tool for JMeter, which support many features

I suggest adding its latest jar to lib/ext folder by default

Approved in Plugins group: https://groups.google.com/forum/#!topic/jmeter-plugins/6eO1ZuQ8pCo

"I see no problem for JMeter core to include Plugins Manager JAR into release archives. Andrey Pokhilko "

[asfimport]

orimarko (migrated from Bugzilla): Need to add the file to lib/ext

Created attachment patch63459.patch: Add plugins to lib/ext

patch63459.patch

Index: lib/ext/jmeter-plugins-manager-1.3.jar
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: lib/ext/jmeter-plugins-manager-1.3.jar
===================================================================
--- lib/ext/jmeter-plugins-manager-1.3.jar	(nonexistent)
+++ lib/ext/jmeter-plugins-manager-1.3.jar	(working copy)

Property changes on: lib/ext/jmeter-plugins-manager-1.3.jar
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+application/octet-stream
\ No newline at end of property

[asfimport]

@vlsi (migrated from Bugzilla):

1. -1 to committing jar files under source control
2. JMeter Plugins defaults (see https://jmeter-plugins.org/repo/) to "http://" URLs, so it would open remote code execution issues to JMeter users which is bad to ship by default

I think the exact implementation (if there's an agreement to ship J-P by default) should go after Gradle migration.

[asfimport]

@vlsi (migrated from Bugzilla): Note: even in case Plugins Manager is shipped by default, users would still have to reinstall the plugins.

I'm not sure a mere inclusion of Plugins Manager would change much for user experience.

[asfimport]

Sebastian Boga (migrated from Bugzilla): If I am sending you a script via email or skype and in my script I am using a certain plugin (let's say Dummy Sampler or Custom JMeter Functions) then this Plugins Manager is automatically identifying what you need in order to open my script, it will install it automatically and open the script without errors.

In case you have only JMeter core, an error message will be displayed saying that JMeter doesn't understand jmx file and from that error you don't understant too much or what you need.

From a user point of view (my ponint of view) knowing that any jmx file you can open without really knowing the exact plugins you need to install, make a huge difference not only form experience point of view but also from time spent (or wasted) when trying to open any jmx script from the team you are working with.

[asfimport]

@pmouawad (migrated from Bugzilla): Hello

@Orimarko, thanks for patch, but I don't think the patch is complete, it only excludes plugins-manager from being committed.

A better patch would be to include in build the plugin and put it in lib/ext.

But we need to ensure that it complies with Apache policies:

• License is ok as it's under Apache 2
• I have a doubt regarding the tracking, I think it's ok but I am not sure:

https://github.com/undera/jmeter-plugins-manager/blob/55acd003468317af11e2576326987b7714f8e938/src/main/java/org/jmeterplugins/repository/JARSourceHTTP.java#L433

Regards

[asfimport]

@FSchumacher (migrated from Bugzilla): I am not convinced that including the plugin manager in JMeter is a good idea.

• Apache is not about distributing binaries, but source.
• If we would include plugin manager without change, we would adore one vendor (the plugin site), which is against Apache policy

I believe this has been discussed before on the mailing list and should be discussed there again, if the old arguments are not valid anymore.

[asfimport]

orimarko (migrated from Bugzilla): License is ok as it's under Apache 2 according to site https://jmeter-plugins.org/wiki/PluginsManager/

[asfimport]

orimarko (migrated from Bugzilla): About statistics tracking it can be remove by define property "jpgc.repo.sendstats" as false, See

https://github.com/undera/jmeter-plugins-manager/blob/5a985589aea4b548bf95815ca6d1fa19da1fb91f/src/main/java/org/jmeterplugins/repository/PluginManager.java#L102

[asfimport]

@pmouawad (migrated from Bugzilla): (In reply to orimarko from comment 10)

About statistics tracking it can be remove by define property "jpgc.repo.sendstats" as false, See

https://github.com/undera/jmeter-plugins-manager/blob/ 5a985589aea4b548bf95815ca6d1fa19da1fb91f/src/main/java/org/jmeterplugins/ repository/PluginManager.java#L102

Thanks.

@Felix, we can distribute it with empty repository url to avoid favoring any site.

An alternative would be for plugins manager to contribute the plugin which we could adapt.

Regarding stats, we could replace them by an Apache hosted system if anything is available which I am not sure about.

It would be nice if we could end up with a tool similar to what Eclipse or Jenkins provide.

[asfimport]

Sebastian Boga (migrated from Bugzilla): what has been decided for this issue?

[asfimport]

orimarko (migrated from Bugzilla): Can we add jmeter-plugins-manager-1.7.jar and JMeter property jpgc.repo.sendstats=false to JMeter?