s3Connector changes for regions apart from aws default regions

[neerajgrg]

[amit-jain]

@neerajgrg The changes lgtm. But have you run the full suite of tests? I would expect that the testing is done for atleast eu_ireland, us standard and one other maybe singapore.

[neerajgrg]

@amit-jain Have run the test file TestS3DSWithSSES3 with eu_ireland, us standard and singapore region. All the test cases are working fine in this class. Please let me know if any other test cases needed to run

[amit-jain]

@neerajgrg Yes please run all tests not just this class.

[neerajgrg]

@amit-jain All test cases are working fine.

[neerajgrg]

tested with all three regions eu_ireland, us standard and singapore.

[amit-jain]

Thanks @neerajgrg for confirming, will take over.

[amit-jain]

@neerajgrg is there a jira issue associated with the PR? Please create one if not available.

[neerajgrg]

@amit-jain can you please direct me to jira dashboard where should i create this jira ?

[amit-jain]

Created https://issues.apache.org/jira/browse/OAK-9128

[amit-jain]

Patch committed. Thanks! @neerajgrg this PR can be closed now.

[neerajgrg]

Thanks @amit-jain I need this patch for AEM 6.5, for that i think we need to merge this path in branch 1.10 as well. Please let me know do i raise a new pull request for that?

[reschke]

1.22, not1.10 (1.10 is retired)

[neerajgrg]

okay, have a raised a pull request on 1.22 - https://github.com/apache/jackrabbit-oak/pull/237 . @amit-jain please review

[amit-jain]

Don't need a PR for it, will merge from trunk.

[github-actions[bot]]

This PR is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 30 days.

[mreutegg]

Change has been committed to SVN: http://svn.apache.org/viewvc?rev=1879352&view=rev