iotdb icon indicating copy to clipboard operation
iotdb copied to clipboard

Pipe: Implemented tree auth check for source + write-back-sink

Open Caideyipi opened this issue 3 months ago • 2 comments

Description

As the title said.


This PR has:

  • [ ] been self-reviewed.
    • [ ] concurrent read
    • [ ] concurrent write
    • [ ] concurrent read and write
  • [ ] added documentation for new or modified features or behaviors.
  • [ ] added Javadocs for most classes and all non-trivial methods.
  • [ ] added or updated version, license, or notice information
  • [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage.
  • [ ] added integration tests.
  • [ ] been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Caideyipi avatar Sep 30 '25 06:09 Caideyipi

Codecov Report

:x: Patch coverage is 27.29560% with 578 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 39.17%. Comparing base (b6c13d7) to head (3239b3d). :warning: Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...chemaregion/PipePlanTreePrivilegeParseVisitor.java 0.00% 167 Missing :warning:
...pe/source/PipeConfigTreePrivilegeParseVisitor.java 55.42% 78 Missing :warning:
...e/source/schemaregion/IoTDBSchemaRegionSource.java 4.87% 39 Missing :warning:
...e/iotdb/db/queryengine/plan/parser/ASTVisitor.java 0.00% 36 Missing :warning:
...an/relational/security/TreeAccessCheckVisitor.java 0.00% 29 Missing :warning:
...db/pipe/sink/protocol/writeback/WriteBackSink.java 0.00% 22 Missing :warning:
...e/manager/pipe/source/IoTDBConfigRegionSource.java 23.07% 20 Missing :warning:
...ion/config/executor/ClusterConfigTaskExecutor.java 0.00% 16 Missing :warning:
...mon/tablet/PipeInsertNodeTabletInsertionEvent.java 50.00% 15 Missing :warning:
...e/plan/execution/config/TreeConfigTaskVisitor.java 0.00% 14 Missing :warning:
... and 28 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16531      +/-   ##
============================================
+ Coverage     39.04%   39.17%   +0.13%     
- Complexity      207      212       +5     
============================================
  Files          5023     5051      +28     
  Lines        333410   335520    +2110     
  Branches      42433    42783     +350     
============================================
+ Hits         130175   131436    +1261     
- Misses       203235   204084     +849     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 30 '25 09:09 codecov[bot]