iotdb icon indicating copy to clipboard operation
iotdb copied to clipboard

Introduce JoinNode logical plan

Open Beyyes opened this issue 1 year ago • 2 comments

Description

Content1 ...

Content2 ...

Content3 ...


This PR has:

  • [ ] been self-reviewed.
    • [ ] concurrent read
    • [ ] concurrent write
    • [ ] concurrent read and write
  • [ ] added documentation for new or modified features or behaviors.
  • [ ] added Javadocs for most classes and all non-trivial methods.
  • [ ] added or updated version, license, or notice information
  • [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage.
  • [ ] added integration tests.
  • [ ] been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Beyyes avatar Aug 26 '24 14:08 Beyyes

Codecov Report

Attention: Patch coverage is 82.85714% with 174 lines in your changes missing coverage. Please review.

Project coverage is 41.35%. Comparing base (51ee13b) to head (46bf13c). Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...an/relational/planner/optimizations/JoinUtils.java 63.26% 54 Missing :warning:
...ngine/plan/relational/planner/RelationPlanner.java 78.46% 42 Missing :warning:
...ine/plan/relational/planner/EqualityInference.java 86.09% 26 Missing :warning:
...nner/optimizations/PushPredicateIntoTableScan.java 93.42% 14 Missing :warning:
...ngine/plan/planner/plan/node/PlanGraphPrinter.java 0.00% 12 Missing :warning:
...yengine/plan/relational/planner/node/JoinNode.java 87.95% 10 Missing :warning:
...ryengine/plan/relational/planner/QueryPlanner.java 72.22% 5 Missing :warning:
...queryengine/plan/relational/utils/DisjointSet.java 94.11% 3 Missing :warning:
.../apache/iotdb/commons/partition/DataPartition.java 81.25% 3 Missing :warning:
...ne/plan/relational/analyzer/StatementAnalyzer.java 94.59% 2 Missing :warning:
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13304      +/-   ##
============================================
+ Coverage     41.04%   41.35%   +0.30%     
  Complexity       71       71              
============================================
  Files          3945     3957      +12     
  Lines        243598   244729    +1131     
  Branches      29477    29632     +155     
============================================
+ Hits          99990   101197    +1207     
+ Misses       143608   143532      -76     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 26 '24 15:08 codecov[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar Sep 04 '24 10:09 sonarqubecloud[bot]