iotdb icon indicating copy to clipboard operation
iotdb copied to clipboard

Remove duplicate point calculate because of consensus and so on

Open SpriCoder opened this issue 1 year ago • 2 comments

Because we need to know the actual external writing point, I try to add isGenerateByConsensus parameters in PlanNode and try to remove duplicate points.

SpriCoder avatar May 05 '24 11:05 SpriCoder

Codecov Report

Attention: Patch coverage is 63.79310% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 42.94%. Comparing base (a9c27bb) to head (bb8ecc6). Report is 23 commits behind head on master.

:exclamation: Current head bb8ecc6 differs from pull request most recent head 86221ee

Please upload reports for the commit 86221ee to get more accurate results.

Files Patch % Lines
...ngine/plan/scheduler/load/LoadTsFileScheduler.java 0.00% 10 Missing :warning:
...lanner/plan/node/write/InsertMultiTabletsNode.java 0.00% 3 Missing :warning:
...e/plan/planner/plan/node/write/InsertRowsNode.java 0.00% 3 Missing :warning:
...ner/plan/node/write/InsertRowsOfOneDeviceNode.java 0.00% 3 Missing :warning:
...dataregion/IoTConsensusDataRegionStateMachine.java 0.00% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12459      +/-   ##
============================================
- Coverage     43.35%   42.94%   -0.42%     
  Complexity       69       69              
============================================
  Files          3166     3193      +27     
  Lines        196844   199181    +2337     
  Branches      23443    23745     +302     
============================================
+ Hits          85349    85540     +191     
- Misses       111495   113641    +2146     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 05 '24 12:05 codecov[bot]

Test in IoTConsensus: image

SpriCoder avatar May 28 '24 11:05 SpriCoder

Test in Ratis Consensus: image

SpriCoder avatar May 28 '24 12:05 SpriCoder

Test on 1 node failed: image

SpriCoder avatar May 29 '24 11:05 SpriCoder

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
11.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 29 '24 12:05 sonarqubecloud[bot]