apache
smaller PR for parquet
Important Read
- Please ensure the GitHub issue is mentioned at the beginning of the PR
What is the purpose of the pull request
(For example: This pull request implements the sync for delta format.)
Brief change log
(for example:)
- Fixed JSON parsing error when persisting state
- Added unit tests for schema evolution
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
- Added integration tests for end-to-end.
- Added TestConversionController to verify the change.
- Manually verified the change by running a job locally.
@the-other-tim-brown I marked as resolved all of your addressed reviews and comments here. To me except few other minor comments here, the main work still to be done is adding the test for the file schema through seperate methods for the statsExtractor. In a subsequent update we could adress further minor issues with this code.
@the-other-tim-brown all of your reviews hav been addressed and the updates have been pushed.
